Skip to content

Added support to all languages - #302

Open
edgardmessias wants to merge 1 commit into
aaron-bond:masterfrom
edgardmessias:all_languages
Open

Added support to all languages#302
edgardmessias wants to merge 1 commit into
aaron-bond:masterfrom
edgardmessias:all_languages

Conversation

@edgardmessias

Copy link
Copy Markdown

How it works: Generate a map of language configuration map, base on all extensions

Abstract:
Each language-configuration.json may contains:
comments.blockComment - The begin and end token used to mark a block comment. Used by the 'Toggle Block Comment' command.
comments.lineComment - The begin token used to mark a line comment. Used by the 'Add Line.

You can read more here: https://code.visualstudio.com/docs/extensionAPI/extension-points#_contributeslanguages

@edgardmessias

Copy link
Copy Markdown
Author

@aaron-bond

Copy link
Copy Markdown
Owner

This is such a neat idea - I've been considering something like this for a while, but didn't know the language config was a thing (is it recent?).

I have to get my dev environment set up again (it's been offline since WFH started), but once I do this is the first thing I'm going to look at.

Thanks!

@texastoland

Copy link
Copy Markdown

@edgardmessias Would you be interested in publishing your fork in the meantime?

@aaron-bond

Copy link
Copy Markdown
Owner

I totally forgot to reply here. @edgardmessias I have a working branch now with these changes (mostly ported your ideas, but I hope you understand I needed to write it myself so I could support it in the future). Many many thanks for your direction, it was invaluable.

https://github.com/aaron-bond/better-comments/tree/all-languages

At the minute the main thing I have to change is removing the activation events, but otherwise this is in test. I'm just looking to make sure I don't break anything for anyone when I release.

@texastoland

texastoland commented Nov 14, 2021

Copy link
Copy Markdown

It looks like the Code team is about to release beta testing for extensions (microsoft/vscode#15756 (comment))! Would you want to publish a beta VSIX in the meantime and announce it on Twitter?

@texastoland

Copy link
Copy Markdown

I've been thinking about this for quit a while. It isn't performant, it updates with noticeable lag, and it doesn't respect the user's theme in any way. Language injection simlar to JSDoc syntax highlighting would solve all these. I'll give it a shot in the next month and release it as a separate project unless @aaron-bond is still around?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants