Repository navigation
Name note folders and audio after the note and save audio as M4A - #2
Merged
Merged
Conversation
Note folders in Audio and Transcripts, and the recordings inside, now carry the note's title instead of an identifier. Renaming a note renames them. The job URLs and the rename list are committed together in history.json, and relaunch finishes an interrupted rename. Kept audio is AAC in an M4A file at 48 kbit/s, about 22 MB per hour instead of 115 MB. Recording still writes PCM to a CAF so a crash keeps the audio; the CAF is converted when the note ends and removed after a frame-count check. On launch, notes from earlier versions are named and their CAF recordings converted, with the originals moved to the Trash. Scripts and CI pass --build-system native: the default build system in Xcode 27 compiles the mlx-swift Metal sources and needs the Metal Toolchain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
AudioandTranscripts, and its recording, carry the note's title instead of an identifier:Audio/Lesson 1/Lesson 1.m4a. A note with both sources getsLesson 1 - You.m4aandLesson 1 - Others.m4a. Renaming a note renames them. A second note with the same title getsLesson 1 2.history.jsonbefore anything moves. Relaunch finishes an interrupted rename, and a failed rename is put back.--build-system native. The default build system in Xcode 27 compiles themlx-swiftMetal sources and fails without the Metal Toolchain component.Checks
docs/audio-storage-and-cleanup.md.Not done