Repository navigation
fix: address #218, #221, #222, #224 - #345
Merged
techisigu merged 9 commits intoOct 24, 2026
Merged
Conversation
…conciliation and Closes Zenith-options#218
…le-Aware NAV and Closes Zenith-options#221
…tifact Publicatio Closes Zenith-options#222
…rkflow for Vault Closes Zenith-options#224
|
@Debbys-design Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- .release-please-manifest.json: merged [markers] — model resolved the conflict markers - docs/security/invariants.md: merged [markers] — model resolved the conflict markers - messages/en.json: merged [markers] — model resolved the conflict markers - release-please-config.json: merged [markers] — model resolved the conflict markers - src/lib/api/vaults.ts: merged [markers] — model resolved the conflict markers Co-authored-by: Simple Agent <agent@simple.dev>
- .github/workflows/ci.yml: merged [markers] — model resolved the conflict markers - src/lib/api/vaults.ts: merged [markers] — model resolved the conflict markers Co-authored-by: Simple Agent <agent@simple.dev>
- src/lib/api/vaults.ts: merged [markers] — model resolved the conflict markers Co-authored-by: Simple Agent <agent@simple.dev>
- src/lib/api/vaults.ts: merged [markers] — model resolved the conflict markers Co-authored-by: Simple Agent <agent@simple.dev>
- src/lib/api/vaults.ts: merged [markers] — model resolved the conflict markers Co-authored-by: Simple Agent <agent@simple.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: address #218, #221, #222, #224
What was solved
#218 — Build the Nightly On-Chain/Off-Chain Vault Reconciliation and Drift Reporting Job
Add a scheduled and on-demand per-vault reconciliation job that treats on-chain vault state as source of truth, recomputes share supply, collateral balance, last finalized epoch id/NAV, pending queue counts, and cumulative fees, compares them against backend ledgers, and writes a per-field drift report with pass/fail/indeterminate status, metrics, and tolerance-based alerts — diagnostics only, no auto-correction.
Addressed:
#221 — Internationalize the Vault Surfaces With Locale-Aware NAV and Currency Formatting
Internationalize the vault surfaces by moving all user-visible vault strings into the existing message catalogs (namespaced to avoid collisions with the options-chain catalog), and add a shared locale-aware formatter module under src/lib/ that renders collateral amounts, high-precision NAV per share, share quantities, APY/percentages, fiat values, and epoch timestamps/durations using the active locale and the vault's collateral asset decimals. Add a non-English catalog synced through the existing Crowdin pipeline, and ensure high-precision values never lose significant digits.
Addressed:
#222 — Wire Vault Contract Build, Deployment, and Artifact Publication Into CI and Release Please
Add a dedicated GitHub Actions workflow that builds the Rust/Soroban vault contract workspace to WASM with a pinned toolchain, runs contract tests, records the WASM hash, exports the contract spec/ABI as an artifact, and deploys to testnet on release/manual dispatch with a mainnet approval gate. Wire contract changes into release-please so they get changelog entries, and add local build/deploy helper scripts.
Addressed:
#224 — Implement a Timelock and Multisig Approval Workflow for Vault Parameter and Upgrade Changes
Add an on-chain governance workflow for vault parameter and upgrade changes: a proposal lifecycle (propose → multisig approvals → queue → mandatory delay → execute, plus cancel and expiry), configurable threshold/delay stored in vault storage and only changeable through the same workflow, typed privileged actions (fee bps, fee recipient, capacity limits, strategy weights/params, oracle config, upgrade authorization) reachable only via governance, events for every lifecycle stage consumable by the indexer, and backend/API exposure of pending/executed proposals (eta + approval count) for a read-only operator console view.
Addressed:
Changes
ORDER_TICKET_BACKEND.md(modify)src/lib/api/vaults.ts(modify)src/lib/format.ts(modify).release-please-manifest.json(modify)release-please-config.json(modify)crowdin.yml(modify).github/workflows/ci.yml(modify)docs/governance-proposal-wizard.md(modify)docs/security/invariants.md(modify)messages/en.json(modify)Approach
Issues
Closes #218
Closes #221
Closes #222
Closes #224