Repository navigation
Fix: Replace the /vaults Mock Data Path With Live Vault Data - #332
Merged
techisigu merged 8 commits intoOct 24, 2026
Merged
Conversation
Remove MOCK_VAULTS and the mock-data disclaimer. The adapter now calls
GET /api/v1/vaults and GET /api/v1/vaults/{id} (404 -> null). Both pages
gate on useFlag("vaults") and show explicit unavailable, loading, error,
and empty states. Fields the backend does not serve render as an em dash
instead of zero. Deposit and withdraw return a not-yet-available error
rather than fabricated transaction IDs.
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
|
@silky50882748y Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- src/app/[locale]/vaults/[id]/page.tsx: merged [markers] — model resolved the conflict markers - src/app/[locale]/vaults/page.tsx: merged [markers] — model resolved the conflict markers - src/lib/api/vaults.ts: merged [markers] — model resolved the conflict markers Co-authored-by: Simple Agent <agent@simple.dev>
- src/lib/api/vaults.ts: merged [markers] — model resolved the conflict markers Co-authored-by: Simple Agent <agent@simple.dev>
- src/app/[locale]/vaults/[id]/page.tsx: merged [markers] — model resolved the conflict markers - src/lib/api/vaults.ts: merged [markers] — model resolved the conflict markers Co-authored-by: Simple Agent <agent@simple.dev>
- src/app/[locale]/vaults/[id]/page.tsx: merged [markers] — model resolved the conflict markers - src/app/[locale]/vaults/page.tsx: merged [markers] — model resolved the conflict markers - src/lib/api/vaults.ts: merged [markers] — model resolved the conflict markers Co-authored-by: Simple Agent <agent@simple.dev>
- src/app/[locale]/vaults/[id]/page.tsx: merged [markers] — model resolved the conflict markers - src/lib/api/vaults.ts: merged [markers] — model resolved the conflict markers Co-authored-by: Simple Agent <agent@simple.dev>
- src/app/[locale]/vaults/[id]/page.tsx: merged [markers] — model resolved the conflict markers - src/lib/api/vaults.ts: merged [markers] — model resolved the conflict markers Co-authored-by: Simple Agent <agent@simple.dev>
- src/app/[locale]/vaults/[id]/page.tsx: merged [markers] — model resolved the conflict markers - src/lib/api/vaults.ts: merged [markers] — model resolved the conflict markers Co-authored-by: Simple Agent <agent@simple.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #193.
Opened automatically by autosolve-cli.
Closes #193