Skip to content

feat(timelock): reconstruct the crate — three roles, predecessors, derived ids #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
techisigu merged 17 commits into from
Oct 24, 2026
Merged

feat(timelock): reconstruct the crate — three roles, predecessors, derived ids #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c900d1d
feat(timelock): reconstruct the crate — three roles, predecessors, de…
tesleem-28 Oct 19, 2026
1a056a9
docs: put the governance docs under docs/
tesleem-28 Oct 19, 2026
77af259
feat(timelock): reconstruct the crate - three roles, predecessors, de…
tesleem-28 Oct 19, 2026
5b852a6
feat(timelock): reconstruct the crate - three roles, predecessors, de…
tesleem-28 Oct 19, 2026
1381d59
fix(build): unblock the workspace build
tesleem-28 Oct 20, 2026
6803253
fix(build): unblock the workspace build and the fmt gate
tesleem-28 Oct 20, 2026
9345637
fix(build): pin the dependency resolution and the remaining workspace…
tesleem-28 Oct 20, 2026
0f35a0b
fix(ci): restore the repaired workflow and the dependency pin
tesleem-28 Oct 20, 2026
747bdb6
fix(timelock): the predecessor cannot be an Option in a contracttype …
tesleem-28 Oct 20, 2026
274994f
fix(ci): give each matrix job the crate it names
tesleem-28 Oct 20, 2026
3816f8e
feat(timelock): the three-role timelock, with derived operation ids
tesleem-28 Oct 20, 2026
62ebf45
fix(timelock): import the id preimage type and apply rustfmt
tesleem-28 Oct 20, 2026
bf60ef6
fix(timelock): borrow the harness env once, and import the mock-auth …
tesleem-28 Oct 20, 2026
15c6217
fix(timelock): mock the authorization, not set it
tesleem-28 Oct 20, 2026
271ff9f
fix(timelock): use the derived operation id in the tests
tesleem-28 Oct 20, 2026
c26c633
fix(vault): drop the crate-level inner attribute from a module file
tesleem-28 Oct 20, 2026
445f3cc
style(vault): format the token validation module
tesleem-28 Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ env:
# multisig build step above runs before the vault build step, not just
# before options_market's.
#
crate: [options_market, price_oracle, vault, multisig, streams, staking, timelock, governor, lp_token, lp_pool, integration_tests]
jobs:
fmt:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
crate: [options_market, price_oracle, vault, multisig, common, streams, staking, timelock, governor, params, grants_escrow, lp_token, lp_pool, integration_tests, tools/spec-diff, tools/resource-sna
crate: [options_market, price_oracle, vault, multisig, common, streams, staking, timelock, governor, params, grants_escrow, lp_token, lp_pool, integration_tests, tools/spec-diff, tools/resource-snapshot]
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
Expand All @@ -53,6 +53,7 @@ jobs:
clippy:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
crate: [options_market, price_oracle, vault, multisig, common, streams, staking, timelock, governor, params, grants_escrow, lp_token, lp_pool, integration_tests, tools/spec-diff, tools/resource-snapshot]
steps:
Expand All @@ -63,11 +64,12 @@ jobs:
targets: wasm32-unknown-unknown
- uses: Swatinem/rust-cache@v2
- run: cargo xtask check-imports
- run: cargo xtask clippy
- run: cargo xtask clippy -p ${{ matrix.crate }}

test:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
crate: [options_market, price_oracle, vault, multisig, common, streams, staking, timelock, governor, params, grants_escrow, lp_token, lp_pool, integration_tests, tools/resource-snapshot]
steps:
Expand All @@ -77,10 +79,12 @@ jobs:
components: rustfmt
- run: cargo fmt --check
working-directory: ${{ matrix.crate }}
- run: cargo xtask test -p ${{ matrix.crate }}

wasm:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
crate: [options_market, price_oracle, vault, multisig, streams, staking, timelock, governor, params, grants_escrow, lp_token, lp_pool, integration_tests]
steps:
Expand All @@ -89,9 +93,9 @@ jobs:
with:
targets: wasm32-unknown-unknown
- uses: Swatinem/rust-cache@v2
- run: cargo xtask test
- run: cargo xtask build -p ${{ matrix.crate }}

wasm:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -100,16 +104,9 @@ jobs:
targets: wasm32-unknown-unknown
- uses: Swatinem/rust-cache@v2
- run: cargo xtask build
# Fails if soroban-sdk/testutils
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
with:
targets: wasm32-unknown-unknown
- uses: Swatinem/rust-cache@v2
- run: cargo xtask test

wasm:
check-wasm:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -192,3 +189,4 @@ jobs:
python3 scripts/resource-diff/resource_diff.py
${{ github.event_name == 'pull_request' && format('--base-ref origin/{0}', github.base_ref) || '' }}
options_market

Loading