Repository navigation
Fix the release workflow's shell - #3
Merged
Merged
Conversation
GitHub Actions accepts only built-in shell names or a command template
with {0}, so `shell: zsh` failed every step before it ran. The steps now
run with `zsh -e {0}`, which also stops a step at its first failing command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release workflow failed on its first run (tag v1.0.0) before building anything:
shell: zsh -e {0}.-emakes a step stop at its first failing command. Without it, a faileddittoin the packaging step would be hidden by theshasumafter it.Testing
Ran each step's commands locally with
zsh -e:v1.0.0and rejectsv1.0.x86_64 arm64app at version 1.0.0.unzip -t, plus its checksum.