fix(chat): remove the file-type whitelist from chat attachment uploads#27
Merged
Merged
Conversation
The document-upload button in the chat input restricted selection to .pdf/.docx/.doc/.wps/.txt/.xlsx/.xls/.csv via the input's accept attribute, so other types (e.g. .pptx) could not be picked. Align with the My Space upload behaviour, which applies no type whitelist: drop the accept attribute and allow any file type to be selected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The document-upload button in the chat input limited the file picker to
.pdf/.docx/.doc/.wps/.txt/.xlsx/.xls/.csvthrough the hidden input'sacceptattribute. Other formats such as.pptxcould not be selected at all, even though the backend accepts them.Change
Drop the
acceptwhitelist from the document upload input so any file type can be selected — consistent with the My Space upload flow, which applies no type whitelist (the folder picker alone distinguishes files from folders). The image upload input keeps its image-onlyacceptunchanged.Testing
Manually verified in the chat input: the attachment picker now offers all file types, and image upload behaviour is unchanged.