[PIWEB-23709] fix: PT-PROFILE not depends on tolerances - #133
Merged
RonHeck merged 2 commits intoMar 25, 2026
Conversation
RonHeck
force-pushed
the
hotfix/PIWEB-23709-fix-calculation-of-PT_PROFILE
branch
3 times, most recently
from
March 12, 2026 20:46
5bb39c8 to
5ba06c7
Compare
The original definition defines to calculate the distance between the maximum and minimum dimension. The dimension for a point is calculated by the distance between the measured value and the target/desired value. The originator states to use always "0" for the desired value. But we changed it to support using the desired value attribute if the profile is biased.
RonHeck
force-pushed
the
hotfix/PIWEB-23709-fix-calculation-of-PT_PROFILE
branch
from
March 13, 2026 08:03
5ba06c7 to
0c79fcb
Compare
czgeissler
reviewed
Mar 25, 2026
czgeissler
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original definition states that the distance between the maximum and minimum dimensions should be calculated. The dimension for a point is calculated based on the distance between the measured value and the target/desired value. The author specifies that “0” should always be used for the desired value. However, we have changed this to support the use of the desired value attribute when the profile is shifted.