Skip to content

Use common Super Linter#452

Open
LeoColomb wants to merge 6 commits into
mainfrom
leo/feat/sl
Open

Use common Super Linter#452
LeoColomb wants to merge 6 commits into
mainfrom
leo/feat/sl

Conversation

@LeoColomb
Copy link
Copy Markdown
Member

Pre-requisites

Change Description

This pull request enables Super Linter workflow on this repository.
It will also bring its fixer feature, where fixing fixable linting and formatting issues on the fly.
This requires YOURLS/.github#75.

@cloudflare-workers-and-pages
Copy link
Copy Markdown
Contributor

cloudflare-workers-and-pages Bot commented May 17, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
website 7bfee95 Commit Preview URL

Branch Preview URL
May 24 2026, 10:34 PM

@LeoColomb LeoColomb marked this pull request as draft May 17, 2026 21:31
@dgw
Copy link
Copy Markdown
Member

dgw commented May 17, 2026

This needs changes to the required status checks, naturally.

Are you planning to replace the lint and format actions in package.json with Super Linter equivalents eventually? It supports running locally, though needs a container engine. https://github.com/super-linter/super-linter/blob/main/docs/run-linter-locally.md

Maybe something lightweight like lilipod would work in lieu of full-fat docker/podman/etc. but no matter what it shouldn't be too bad getting the necessary stuff set up in devcontainer.

@LeoColomb LeoColomb marked this pull request as ready for review May 18, 2026 09:02
@LeoColomb LeoColomb force-pushed the leo/feat/sl branch 2 times, most recently from 8938452 to 541ff2d Compare May 24, 2026 17:33
@LeoColomb LeoColomb requested a review from a team as a code owner May 24, 2026 19:47
@LeoColomb LeoColomb enabled auto-merge (squash) May 24, 2026 22:40
@LeoColomb
Copy link
Copy Markdown
Member Author

LeoColomb commented May 24, 2026

@YOURLS/core Ready to review, fully working now.
See last commit on how Super Linter is submitting a commit with fixes.


Are you planning to replace the lint and format actions in package.json

Not really, to be honest, @dgw.
I tend to prefer not to mix ecosystems.
And Prettier is actually covering 95% of the need for usual contributors.
So, meh ☺️

This needs changes to the required status checks, naturally.

Naturally 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants