[TNT-273] DisplayText 정의 및 적용 - #138
Merged
Merged
Conversation
SeonJeongk
approved these changes
May 6, 2025
SeonJeongk
left a comment
SeonJeongk
left a comment
Contributor
There was a problem hiding this comment.
고생하셨습니다요! 깔끔하니 좋네요👍
트레이니 화면들에도 적용해보겠습니다
Comment on lines
5
to
6
| <string name="session_expired">세션이 만료되었어요</string> | ||
| <string name="session_expired_description">장시간 미사용으로 로그인 화면으로 이동해요</string> |
Contributor
There was a problem hiding this comment.
접두사로 core 붙이는거 좋습니다! 그럼 얘네도 core를 붙여야 하지 않을까용?
hoyahozz
marked this pull request as ready for review
July 6, 2025 10:26
SeonJeongk
approved these changes
Aug 8, 2025
SeonJeongk
left a comment
SeonJeongk
left a comment
Contributor
There was a problem hiding this comment.
고생 많으셨습니다! 🙌
수정 사항이랑 궁금한 점 몇 가지 리뷰 남겨뒀습니다.
확인하시고 문제 없으면 바로 머지해주세요!
Comment on lines
+7
to
+8
| <string name="core_terms_of_service">서비스 이용약관</string> | ||
| <string name="core_privacy_policy">개인정보 처리방침</string> |
Contributor
There was a problem hiding this comment.
core 모듈의 문자열 리소스를 사용하지 않고 따로 추가해두신 이유가 있을까요??
Member
Author
There was a problem hiding this comment.
얽 잘못 넣어뒀네요! 제거 완료하였습니다.!
Comment on lines
-52
to
+54
| import co.kr.tnt.core.designsystem.R | ||
| import co.kr.tnt.core.designsystem.R.drawable.ic_close | ||
| import co.kr.tnt.core.designsystem.R.drawable.ic_image | ||
| import co.kr.tnt.core.designsystem.R.drawable.ic_overlay_close |
Contributor
There was a problem hiding this comment.
drawable을 개별 import로 쓰신 이유가 가독성 때문일까요?
앞으로 core 모듈의 문자열, 이미지 리소스들은 전부 개별 import 방식으로 통일해 사용하는 건지 궁금합니다!
Member
Author
There was a problem hiding this comment.
[안드로이드 팀 합의]
ui > core모듈 내에 위치한 문자열 / 이미지 리소스 사용 시 개별import방식으로 사용하도록 협의- 모듈 내에 위치한
R을 사용할 때만R.string.~형태로 사용하도록 협의
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
Closes [TNT-273] 텍스트 string resource 적용 #137
API단에서 내려주는 문자열과, 애플리케이션 자체적으로 제공하는 문자열 리소스 중 한 가지를 동적으로 선택하여 화면상으로 출력해야 하는 경우가 있습니다.
DisplayText를 구현하였습니다.📸 실행 화면
🙆🏻 리뷰 요청 사항
core하게 애플리케이션 전체에서 사용하는 문자열 리소스의 경우, 접두사에core를 붙이는거 어떻게 생각하시나요?alias를 통해coreR형태로 자주 사용했었는데, 일일이 붙여주는 것도 번거롭고 사람마다 다르게 붙일 여지가 있어보여요.👀 레퍼런스