[TNT-260] 트레이너 내 정보 수정 - #129
Merged
Merged
Conversation
SeonJeongk
reviewed
May 29, 2025
SeonJeongk
left a comment
SeonJeongk
left a comment
Contributor
There was a problem hiding this comment.
고생하셨습니다악!
완료 버튼 활성화 여부만 수정 부탁드립니다👍
Comment on lines
+147
to
+150
| TnTBottomButton( | ||
| text = "완료", | ||
| onClick = onClickComplete, | ||
| ) |
Contributor
There was a problem hiding this comment.
수정사항이 있을 경우에만 활성화 될 수 있도록 수정해주세용
hoyahozz
marked this pull request as ready for review
July 29, 2025 13:42
SeonJeongk
approved these changes
Aug 8, 2025
SeonJeongk
left a comment
SeonJeongk
left a comment
Contributor
There was a problem hiding this comment.
넘 고생하셨습니다~!
머지되면 트레이니 정보 수정 PR도 수정해서 올리겠습니다 :-)
Comment on lines
+3
to
+12
| object UserProfilePolicy { | ||
| // TnT 에서 사용자가 업로드할 수 있는 이미지의 최대 용량은 10MB이다. | ||
| const val USER_IMAGE_MAX_SIZE = 10 * 1024 * 1024 | ||
|
|
||
| // TnT 에서 사용자가 입력할 수 있는 이름의 최대 길이는 15자이다. | ||
| const val USER_NAME_MAX_LENGTH = 15 | ||
|
|
||
| // TnT 에서 사용자가 입력할 수 있는 이름은 한글, 영어, 공백만 허용한다. | ||
| val USER_NAME_REGEX = Regex("^[a-zA-Zㄱ-ㅎㅏ-ㅣ가-힣 ]+\$") | ||
| } |
Contributor
There was a problem hiding this comment.
정책을 따로 분리해두니 훨씬 깔끔하고 좋네요..! 전부 적용하시느라 고생 많으셨습니다 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
📸 실행 화면
default.mov
🙆🏻 리뷰 요청 사항
Repository Cache를 적용해보았습니다!👀 레퍼런스