[CHA-77] fix: 저장된 결과 더보기 조회 API 연결 - #261
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
DongjaJ
approved these changes
Aug 21, 2026
Comment on lines
+29
to
+42
| const comparisonsQuery = useQuery({ | ||
| ...getMyChannelComparisonsOptions({ | ||
| query: { page: pages.comparison - 1, size: SAVED_RESULTS_PAGE_SIZE }, | ||
| }), | ||
| enabled, | ||
| retry: false, | ||
| }); | ||
| const simulationsQuery = useQuery({ | ||
| ...getMySimulationsOptions({ | ||
| query: { page: pages.simulation - 1, size: SAVED_RESULTS_PAGE_SIZE }, | ||
| }), | ||
| enabled, | ||
| retry: false, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
무엇을 변경했나요?
/mypage/saved-results화면에서 저장된 채널 추천·비교·시뮬레이션 조회 API를 연결했습니다.wordmarkUrl을 사용하도록 매핑되는지 검증하고, 값이 없을 때 기존 fallback 이미지를 사용하도록 테스트했습니다.iconUrl및 추천 채널 이미지가cdn.chaeso.zip에서 로드될 수 있도록 Next Image 원격 이미지 도메인을 허용했습니다.왜 변경했나요?
기존 저장된 결과 더보기 화면이 실제 조회 API와 연결되지 않아 사용자의 저장 결과를 정상적으로 확인할 수 없었습니다. 또한 채널 추천·비교 상세에서 API가 제공하는 채널 이미지가 원격 이미지 도메인 설정으로 차단될 수 있어 화면에 정상적으로 표시되도록 보완했습니다.
Linear: https://linear.app/chaesozip/issue/CHA-77/feature-저장된-결과-탭-및-목록
Closes CHA-77
확인 사항
필수 확인
node --run build통과 — Next 최적화 단계에서 약 2분간 추가 출력 없이 진행되어 중단했습니다.node --run lint통과 — 기존tests/design-tokens.test.js의 상대 경로 import 경고 3건이 있습니다.node --run test:ci -- src/pages/recommend-result/model/recommended-channels.test.ts src/pages/compare/model/channel-comparison-adapter.test.ts src/pages/compare/ui/compare-result-channel-cards.test.tsx(3 files, 23 tests)Closes CHA-77기능 검증
설정 및 문서
해당되는 경우