[Fix] 회원가입 온보딩 스크린 로직 수정 - #159
Merged
Merged
Conversation
네트워크 요청의 안정성을 확보하기 위해 `HttpTimeout`의 주요 설정 값을 기존 10~15초에서 100초로 일괄 상향 조정합니다. - `requestTimeoutMillis`: 15,000ms -> 100,000ms - `connectTimeoutMillis`: 10,000ms -> 100,000ms - `socketTimeoutMillis`: 15,000ms -> 100,000ms
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # feature/onboarding/src/main/java/com/kikidan/onboarding/OnboardingViewModel.kt # feature/onboarding/src/test/java/com/kikidan/onboarding/OnboardingViewModelTest.kt
온보딩 최종 제출 상태를 관리하는 `OnboardingSubmitState`를 UI 레이어에 일관되게 적용하고, 불필요한 코드를 정리합니다. - `OnboardingRoute`: `CompleteScreen`의 `isLoading` 인자를 기존 `state.isSubmitting` 대신 `state.submitState`가 `Loading` 상태인지 확인하는 로직으로 변경 - `OnboardingViewModel`: 중복으로 포함된 `OnboardingSubmitState` 임포트 구문 제거
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
변경사항 / 상세
중점 리뷰사항
스크린샷 (선택)