SajuCard 잘림 현상 수정 - #149
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
SajuCard)가 일부 기기(좁은 화면 폭 / 시스템 글자 크기 확대)에서 텍스트가 잘려 보이는 현상 수정변경사항 / 상세
SajuCard는Modifier.weight(1f)+aspectRatio(1f)로 화면 폭에 비례한 정사각형 박스를 만드는데, 내부 텍스트(한자body1Bold18sp + 읽는법caption3Regular10sp, 합산 lineHeight 39sp + 세로 padding 12dp)는 폭과 무관한 고정 sp 값이라 박스가 좁아지면 필요한 높이보다 작아져clip(RoundedCornerShape)에 의해 잘리는 문제가 있었음aspectRatio(1f)앞에heightIn(min = 64.dp)를 추가해, 폭이 좁아 정사각형 높이가 텍스트가 필요로 하는 최소 높이보다 작아지는 경우엔 세로로 살짝 늘어난 직사각형이 되도록 처리(폭이 충분할 때는 기존과 동일하게 정사각형 유지)중점 리뷰사항
heightIn(min = 64.dp)값이 실제 좁은 폭/큰 글자 설정 기기에서 충분한 여유인지 확인 부탁드립니다스크린샷 (선택)