Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this PR
When running algorithms in the GPxQ family, we need to quantize one column at the time.
For groupwise quantization, currently there is no way to quantize a single column without quantizing wastefully the entire matrix.
The main issue is related to the groupwise dependency on adjacent columns, and the shape manipulation we do when applying groupwise quantization.
This PR addresses that.
Some results for the following configuration:
End-to-end GPTQ
Groupwise INT8, eager
Llama 8b
Qwen3 14B
Groupwise quantization, layer shape [4096, 14436]
MXINT8
MXFP8
Groupwise INT8 (with zero point)
These were measured with the following utility