Repository navigation
Add stylesheet hotloading for DEBUG builds #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7f5add1
14d0088
f464695
fce6c52
1a20a34
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -341,4 +341,22 @@ internal void BuildStyleRules() | |
|
|
||
| styleRuleUpdates.Clear(); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Dirty all styles on this root panel and its children. | ||
| /// Called when stylesheets are hotloaded to force a complete style rebuild. | ||
| /// </summary> | ||
| internal void DirtyAllStyles() | ||
| { | ||
| DirtyStylesRecursive(); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Call OnHotloaded on this panel and all children. | ||
| /// Called when razor files or stylesheets are hotloaded. | ||
| /// </summary> | ||
| internal void TriggerHotload() | ||
| { | ||
| OnHotloaded(); | ||
| } | ||
|
Comment on lines
+358
to
+361
|
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This static event subscription creates a potential memory leak. Each time
RunPanelis called, a new lambda is subscribed to the static event, but there's no corresponding unsubscription. The lambda capturesrootPanel, which prevents the RootPanel from being garbage collected even after the window closes.Consider either: