Skip to content

Implement Max Flow Scaling for Chord Diagram - #1

Draft
google-labs-jules[bot] wants to merge 1 commit into
new_data25from
feature/scale-chord-diagram
Draft

Implement Max Flow Scaling for Chord Diagram#1
google-labs-jules[bot] wants to merge 1 commit into
new_data25from
feature/scale-chord-diagram

Conversation

@google-labs-jules

Copy link
Copy Markdown

This change implements the feature in index2.html of scaling the geometries according to the scale-toggle parameter selection into the chord-chart.js and index.html trying to keep all the features intact. The values for the maxFlow const doesn't require to be computed as they are already loaded into the drawChart() function in chordData.maxFlows


PR created automatically by Jules for task 8014473800682269449 started by @X80110

This commit introduces a new feature that allows users to scale the chord diagram's outer arcs based on the maximum historical flow values for each region.

- Added a `scaleChordLayout` function to `chord-chart.js` to calculate the scaled chord and group layouts.
- Implemented the scaling logic within the `drawChords` function, which is activated by a new "Use Max Flow for Arc Scale" checkbox.
- Added an event listener to the checkbox in `index.html` to trigger the update of the visualization.
- Added `*.log` to `.gitignore`.
@google-labs-jules

Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants