fix(ci): compute the release checksum from the published wasm - #4
Merged
Conversation
`build-wasm-plugin` emits a dotnet_toolchain.wasm.sha256 that does not match the wasm it leaves next to it in builds/, so the released checksum fails verification for anyone who checks a download by hand. Recompute it from the exact artifact the release step uploads. The step is unconditional so a workflow_dispatch dry-run exercises it, and it fails when no wasm is found rather than quietly leaving the stale file in place. Fixes #2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-wasm-pluginwrites adotnet_toolchain.wasm.sha256that does not match the wasm it leaves beside it inbuilds/, and the release step uploads both as-is. So the published checksum has never matched the published wasm.This adds a step that recomputes the checksum from the exact file the release uploads, right after the publish build. The file format is unchanged (bare hash, no trailing newline), only the value is now correct.
The step is deliberately not gated on tag pushes, so a
workflow_dispatchdry-run still exercises it, and it fails if no wasm turns up rather than quietly leaving a stale checksum in place.The wasm asset itself was never affected. It matches its ghcr OCI layer byte for byte, and moon does not read the
.sha256, which is why this went unnoticed.I've also corrected the v0.1.0 asset in place, so the reported release verifies now rather than only future ones.
Fixes #2