chore(base-foundation): replace Memoizer with a typed hierarchy and builder#93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.base.foundation.Memoizerclass and replaces it with a newbuild.base.foundation.memoizerpackage containing aMemoizer<T,R>interface, a fluent builder, and six concrete implementations covering every combination of reference mode (strong / soft / weak) and threading model (concurrent / non-concurrent).Memoizer.of(fn).soft().concurrent().build()— reference mode and concurrency are opt-in, making intent explicit at each call site.AbstractConcurrentMemoizeruses a per-keyReentrantLockrather thanConcurrentHashMap.computeIfAbsentfor the value cache, which allows memoized functions to safely re-enter the memoizer for keys that share a hash bin without deadlocking.IntrospectionandAbstractHeapBasedIndexare updated to the new API; tests are expanded to a parameterized suite covering all six implementations, including concurrent-load and re-entrancy scenarios.