feat(base-telemetry-javac): extract MessagerBasedTelemetryRecorder#91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
java.compileris a tooling module with no place in a production runtime image. Any library depending onbase-telemetry-foundationpreviously inherited it transitively, which unnecessarily inflated jlink images. The extraction follows the same boundary principle asbase-telemetry-ansi: one module per recorder backend, named for its dependency.base-telemetry-javacmodule containingMessagerBasedTelemetryRecorder, previously inbase-telemetry-foundationrequires java.compilerfrombase-telemetry-foundation, so consumers of the telemetry foundation no longer transitively pull in the compiler tooling modulebuild.base.telemetry.javacand explicitly declaresrequires java.compiler, keeping that dependency scoped to annotation processor consumers only