Repository navigation
Fix image paste and undo handling - #41
Merged
Merged
Conversation
…hat undo restores the original image size and content.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Cancellation can cause out-of-bounds writes, discard independent edits, and leave stale scrollbar state.
3 open issues
What changed in this PR
Preserves the pre-paste image so undo can restore its original dimensions and content.
Changes:
- Saves the original image before paste resizing and reuses it for undo.
- Restores pending paste snapshots on cancellation and clears them on close.
| File | Description |
|---|---|
| src/WinIMergeLib/ImgMergeWindow.hpp | Uses paste-specific resizing and cancellation. |
| src/WinIMergeLib/ImgMergeBuffer.hpp | Manages original-image snapshots for paste undo and cancellation. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary