Skip to content

fix: generate litestream v0.5 retention config#871

Merged
exKAZUu merged 4 commits into
mainfrom
codex/fix-litestream-retention-config
Jun 12, 2026
Merged

fix: generate litestream v0.5 retention config#871
exKAZUu merged 4 commits into
mainfrom
codex/fix-litestream-retention-config

Conversation

@exKAZUu

@exKAZUu exKAZUu commented Jun 12, 2026

Copy link
Copy Markdown
Member

Customer Summary

  • Restores the intended 3-day Litestream backup retention window for projects using the shared Docker setup.
  • Keeps Litestream installation on the latest upstream release by default, while still allowing an explicit LITESTREAM_VERSION override when needed.
  • Avoids Docker build failures from Debian architecture names that do not match Litestream release asset names.

Technical Summary

  • Moves Litestream backup retention settings from the old replica-level v0.3 keys to the v0.5-compatible top-level snapshot.interval and snapshot.retention keys.
  • Removes obsolete retention-check-interval generation because v0.5 enforces snapshot retention during snapshot compaction.
  • Derives the default ARCH value as the Litestream release asset architecture (x86_64 or arm64) and uses it directly in the .deb filename.
  • Preserves optional LITESTREAM_VERSION and ARCH overrides for callers that need them.

Why

  • Production was running Litestream v0.5, but shared still generated v0.3-style retention keys, so the intended 72h retention was not applied.
  • Using v0.5-compatible snapshot config makes the generated /etc/litestream.yml match the Litestream version currently installed by the Docker image.

Testing

  • bash -n packages/wb/docker/bash/install-litestream.sh
  • Verified latest Litestream release asset URLs for linux-arm64 and linux-x86_64 with curl -fsSI.
  • Verified a generated v0.5-style snapshot: config is accepted by Litestream 0.5.12 via litestream databases -config.
  • yarn verify
  • Latest PR CI passed via bunx @willbooster-private/agentic-workflows@latest skills check-pr-ci.

Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request pins the Litestream version in the installation script and refactors the Litestream configuration in the Prisma command to move snapshot settings to the top level. However, a critical issue was found in the installation script where the default version was set to 0.5.12, which is a LiteFS version rather than a Litestream version (the latest stable being 0.3.13). This mismatch will cause the Docker build to fail with a 404 error.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/wb/docker/bash/install-litestream.sh Outdated
exKAZUu and others added 3 commits June 12, 2026 20:15
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
@exKAZUu exKAZUu self-assigned this Jun 12, 2026
@exKAZUu exKAZUu merged commit a1558b3 into main Jun 12, 2026
6 checks passed
@exKAZUu exKAZUu deleted the codex/fix-litestream-retention-config branch June 12, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant