Wildbook shows Create option when a user-entered ID matches an existing historical ID

[goddesswarship]

Expected behavior
When a user enters an ID in an Encounter's Identity field that already matches an existing ID (either by the primary name, alternate ID, other values, etc.) the "Create" option disappears from the menu.

Current behavior
When a user enters an ID in an Encounter's Identity field that already matches an existing ID the "Create" option appears alongside the existing positive match. If the user selects the Create option, the ID that's assigned isn't the one they typed, but the suggested ID they ignored.

QA notes
Reported in Flukebook, replicated in both Flukebook and QA. Consider adding a note below the ID field along the lines of "Suggested IDs include matches by historical or alternate ID" and remove the "Create" option when the entered ID is a match for an existing individual's primary or alternate IDs.

Can test with this encounter in QA: https://flakebook.wildme.org/react/encounter?number=de8cc7d3-c90d-47d0-83c5-74d65ba30446

If you create ID 00000001, it will assign to the suggested ID of 00000213 instead.

Community link
Reported via email.

[naknomum]

technical note: when the PATCH call is sent to the api, the value passed is used by getOrCreateMarkedIndividual(value) to first look for an individual which matches the name, and then (if there is none) create a new one. when the passed user string matches even on an alias, no new individual will be created (and that match will be used).