Repository navigation
refactor: split the last nine UI components - #54
Merged
Merged
Conversation
SetupGuides goes from 487 to 66 lines: each provider guide and the shared step blocks get their own file under setup-guides/.
ReportCanvas goes from 393 to 181 lines: the layout helpers, the toolbar and the grid get their own files.
DirectoryConnections goes from 275 to 119 lines: the connection card and the type and status metadata get their own files.
AlertTable goes from 271 to 166 lines: the alert row and the severity, confidence and status metadata get their own files.
RolesManager goes from 269 to 161 lines: the roles table with its pagination and the role form get their own files.
EmployeeTable goes from 263 to 169 lines: the column definitions and the filter bar get their own files.
WidgetLibrary goes from 226 to 141 lines: the widget card with its scaled preview gets its own file.
DetailDrawerContext goes from 219 to 136 lines: the drawer body with its field list gets its own file.
UserRoleAssignment goes from 215 to 143 lines: the people table with its role and credential actions gets its own file.
Every code file is now at 200 lines or fewer, so the per-file caps and their AGENTS.md mention go away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the code side of #30: the last nine components over 200 lines (setup guides, report canvas, directory connections, alert table, roles manager, employee table, widget library, detail drawer, user role assignment) are split, and the now empty OVER_LIMIT list is removed.
Each split was checked with the same scripted browser session on the old and new code, including step-up, errors and the detail drawer: the rendered HTML is identical. No behaviour change.