Repository navigation
refactor(dashboard): split the dashboard page - #52
Merged
Merged
Conversation
dashboard.ts goes from 408 to 192 lines: the source-filterable series move to dashboard-series.ts with their tests, the other widget breakdowns to dashboard-breakdowns.ts, and an unused re-export of the risk helpers goes. getDashboardData and the three series for every provider return identical JSON on the demo data.
page.tsx goes from 345 to 85 lines: the default and library widget lists move to their own factories and preset loading to src/lib/dashboard-presets.ts. The server-rendered HTML is identical and the RSC payload differs only by bundle file names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #30. The dashboard page and its data builders are split into smaller files under 200 lines.
The preset loader gets its own unit tests. No behaviour change: the same scripted session renders the same dashboard before and after.