Repository navigation
fix(directory): skip Okta users without an email - #44
Merged
Merged
Conversation
A user without an email fell back to its login, which is not always an address. Okta pagination, errors and remediation calls are now covered too.
ldapts is a dependency, so the dynamic import with its install hint goes, and the client gets its real type. AWS loses an unused command import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38 (closed manually on merge, closing keywords do not apply to
develop).Bug
An Okta user without an
emailfell back to itslogin, which is not always an address, so a login likeada.lovelacewas stored and scanned as one. Same defect as the AWS connector fixed in #35. The login is now kept only when it is a valid email.Leftovers
ldap.ts:ldaptsis a dependency, so the dynamic import and its stale "npm install ldapts" hint go, and the LDAP client gets its real type instead ofany.aws.ts: unusedDescribeUserCommandimport and itsvoidline removed.Tests
Okta now covers pagination through the
Linkheader, the active-users filter, the login fallback, API errors, both remediation calls and the connection test. Coverage floor raised (branches 51%, functions 50%).Verified
make checkgreen, integration suite 110/110.