Repository navigation
fix(dashboard): show failed saves with a retry - #43
Merged
Merged
Conversation
Every preset change (layout, switch, create, rename, delete, source, reset) ignored server failures, so a change looked saved and vanished on reload. A failed save now shows a bar with Retry, and rename and delete only apply once the server accepts. The Ctrl+wheel zoom moves to its own hook to keep the file under its cap.
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37 (closed manually on merge, closing keywords do not apply to
develop).Bug
Every dashboard preset change ignored server failures: layout save, switching view, creating, renaming, deleting, changing a widget source, resetting. On a failed request the change looked saved and was lost on reload, or a deleted view came back.
Fix
saveRequest(src/lib/save-request.ts) returnsnullon a refused request or a network error, so a failure cannot be ignored by accident. Unit tested.DashboardCanvas.tsxwas at its 776-line cap: the Ctrl+wheel zoom moves touseCtrlWheelZoom.tsunchanged, and the file drops to 734 lines, with its cap tightened to match.Verified in the browser (requests forced to 500, then allowed)
make checkgreen.