Skip to content

feat(scan): let users dismiss the incomplete banner - #27

Merged
WhiteMuush merged 1 commit into
developfrom
feat/dismiss-scan-banner
Oct 12, 2026
Merged

WhiteMuush merged 1 commit into
developfrom
feat/dismiss-scan-banner

Conversation

@WhiteMuush

Copy link
Copy Markdown
Owner

Summary

The "Scan incomplete" banner on the employees page and the dashboard could not be closed.

  • A close button (top right) hides it.
  • It stays hidden while the scan status is the same: same sources, same counts, same last error.
  • It comes back on its own when a scan changes that status, so a new problem is never hidden.
  • The choice is kept per browser (local storage, same pattern as the widget settings). The Data API page keeps showing the status.

Type of change

  • feat: new feature
  • fix: bug fix
  • chore: maintenance / dependencies
  • docs: documentation
  • refactor: code refactor

Checklist

  • My code follows the project conventions
  • I have tested my changes: unit tests for the status signature, lint, tsc --noEmit, and the banner driven in a real browser (close, reload, status change brings it back, dashboard placement).
  • Related issue: Closes Let users dismiss the scan incomplete banner聽#26

The "Scan incomplete" banner could not be closed. A close button now
hides it until a scan changes the status (which sources missed how many
employees, and why), so a new problem is never hidden. The choice is kept
per browser. The Data API page still shows the status.

Refs #26
@WhiteMuush WhiteMuush self-assigned this Oct 12, 2026
@WhiteMuush
WhiteMuush merged commit 072cf65 into develop Oct 12, 2026
15 checks passed
@WhiteMuush
WhiteMuush deleted the feat/dismiss-scan-banner branch October 14, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant