Repository navigation
fix: use $VAGRANT_CMD in remaining box-remove and sync calls - #4
Merged
Merged
Conversation
Follow-up to the earlier VAGRANT_CMD fix: 'vagrant box remove' (3 sites in vagrant.sh) and inventory_sync's 'vagrant status'/'vagrant ssh' calls were still hardcoded, so box cleanup and 'bull sync' broke on WSL2 with the VirtualBox provider (VAGRANT_CMD=vagrant.exe).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3. Three
vagrant box removecalls inlib/vagrant.shand thevagrant status/vagrant sshcalls ininventory_syncwere still hardcoded, so box cleanup andbull syncbroke on WSL2 + VirtualBox whereVAGRANT_CMD=vagrant.exe. Routes them through${VAGRANT_CMD}like the rest of the codebase.The lone remaining literal
vagrant(vagrant.sh:1452) is a user-facing retry hint string, intentionally left as-is.bash -npasses