Repository navigation
Benchmarks table: the bundler oracle row at 666 of 746 - #26
Merged
Merged
Conversation
#24 moved the esbuild oracle to 666 of 746 (89.3%) in the README and conformance.json, but bench.json's build-tool table still said 667 of 746 at 2a59fe3, so the build tool and benchmarks pages showed two results. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Code reviewThe change corrects the bundler oracle row to 666 of 746 cases (89.3%) at commit 52b87b3, matching the recorded measurement and other site pages. No verified issues found. No issues found. Checked for bugs and AGENTS.md compliance. |
Contributor
|
Preview removed: this pull request is closed. |
![ts-r-review[bot]](https://avatars.githubusercontent.com/u/210539774?s=60&v=4){kind=small}
There was a problem hiding this comment.
ts-r code review of 34dd0c2: no open findings, so this is approved. Checked for bugs and AGENTS.md compliance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #24, from the ts-r review bot's finding there (#24 (comment)):
landing/data/bench.json's build-tool table still had the esbuild oracle at 667 of 746 (89.4%, 2a59fe3), so the build tool and benchmarks pages contradicted the updated correctness rows. It now says 666 of 746 (89.3%) at 52b87b3.No other stale values: I grepped
landing/and README.md for the old binder, emit and bundler numbers.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.