Skip to content

Commit 062798f

Browse files
committed
fixed maven structure
1 parent 773d093 commit 062798f

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

jdk_17_maven/cs/grpc/signal-registration/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
<groupId>io.micronaut</groupId>
1717
<artifactId>micronaut-parent</artifactId>
1818
<version>3.8.0</version>
19+
<relativePath/>
1920
</parent>
2021

2122
<properties>

jdk_17_maven/cs/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
<modules>
1515
<module>web</module>
16+
<module>grpc</module>
1617
</modules>
1718

1819

notes_adding_suts.txt

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ As there are quite a few things to keep in mind, we list here the most important
3434
This is to be able to easily trace the original version of the SUT.
3535
Also, it is EXTREMELY DIFFICULT to review in PRs the EM drivers when you have as well thousands of SUTs files cluttering
3636
the GitHub diff views.
37-
This means there is the need to 2 distinct PRs:
38-
1) having the original SUTs files
37+
THIS MEANS THERE IS THE NEED OF 2 DISTINCT PRs:
38+
1) having the original SUTs files, and only those, ie nothing outside of "jdk_X_Y/cs/<type>/NAME"
3939
2) having all custom modifications (if any needed), pom files and their modifications, and EM drivers (embedded and external)
4040

4141
- under no circumstance should add compiled files. Also large files should be avoided if they are not strictly necessary.
@@ -57,13 +57,16 @@ As there are quite a few things to keep in mind, we list here the most important
5757
The SUT should be buildable from "jdk_X_Y", ie, the tree-structure needs to be defined with the <module> directive
5858
to specify which child subfolders with pom files represent sub-modules.
5959

60+
- Maven: if the SUT root pom.xml file refers to an external <parent>, eg "spring-boot-starter-parent" or "micronaut-parent",
61+
in the parent declaration you might need to add <relativePath/> to avoid an inconsistent Maven structure.
62+
6063
- Gradle: should use same structure "jdk_X_Y/cs/<type>", but the build structure needs to be defined in settings.gradle.kts
6164

6265
- need to choose a NAME for the SUT. usually, it depends on the actual name from GitHub (eg some combination/adaptation
6366
of the "author/name" GitHub identifier), but it does not necessarily mean it must be exactly the same.
6467
Small modifications (especially if the name is generic or very long) can be done.
6568
The reason is that NAME is used everywhere, including in the writing of the scientific articles.
66-
Might want to discuss with supervisor before choosing then NAME (as the change of the name can impact thousands of files
69+
Might want to discuss with supervisor before choosing the NAME (as the change of the name can impact thousands of files
6770
if refactored).
6871

6972
- if the NAME is composed of 2 or more words, use "-" to separate them.

0 commit comments

Comments
 (0)