Skip to content

Commit 773d093

Browse files
committed
signal-registration entry
1 parent f64b661 commit 773d093

2 files changed

Lines changed: 9 additions & 2 deletions

File tree

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,8 @@ For simplicity, all schemas are also available as JSON/YML files under the folde
115115

116116
### RPC (Thrift/gRPC): Java
117117

118+
* Signal-Registration (not-known license), [jdk_17_maven/cs/grpc/signal-registration](jdk_17_maven/cs/grpc/signal-registration), from [https://github.com/signalapp/registration-service]()
119+
118120
* NCS (not-known license, artificial numerical examples coming from different sources)
119121

120122
* SCS (not-known license, artificial string examples coming from different sources)

notes_adding_suts.txt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,17 @@ As there are quite a few things to keep in mind, we list here the most important
5959

6060
- Gradle: should use same structure "jdk_X_Y/cs/<type>", but the build structure needs to be defined in settings.gradle.kts
6161

62-
- need to choose a NAME for the SUT. usually, it depends on the actual name from GitHub, but it does not necessarily mean
63-
it must be exactly the same. Small modifications (especially if the name is generic or very long) can be done.
62+
- need to choose a NAME for the SUT. usually, it depends on the actual name from GitHub (eg some combination/adaptation
63+
of the "author/name" GitHub identifier), but it does not necessarily mean it must be exactly the same.
64+
Small modifications (especially if the name is generic or very long) can be done.
6465
The reason is that NAME is used everywhere, including in the writing of the scientific articles.
6566
Might want to discuss with supervisor before choosing then NAME (as the change of the name can impact thousands of files
6667
if refactored).
6768

69+
- if the NAME is composed of 2 or more words, use "-" to separate them.
6870

71+
- the README.md needs to be updated with info on the new SUT, under the proper group.
72+
Need to specify the license, folder location on EMB, and original source repositories.
73+
See other SUT entries to check exactly how to do it (especially how to add clickable links in Markdown).
6974

7075
- TODO

0 commit comments

Comments
 (0)