fix(woocommerce): use the configured trusted-proxy IP resolver - #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WebDecoy/app#878.
WooCommerce now delegates checkout IP resolution to the configured WebDecoy singleton instead of creating a SignalCollector with an empty trusted-proxy list. Checkout rate limits, attempt records, and payment-failure attribution share the same resolver as the rest of the plugin.
Added regression coverage for distinct shoppers behind a trusted proxy, ignored untrusted forwarding headers, and direct-request spoofing. Added docs/woocommerce-ip-history.md explaining why historical proxy-collapsed attempts cannot be safely backfilled and how to mark the trustworthy deployment boundary.
Validation: php tests/run.php (96 passed, 0 failed), PHP syntax checks, git diff --check.
Created in an isolated worktree; existing release-related edits in the main working checkout are untouched.