Remove close_streams vtable call#824
Merged
Merged
Conversation
This was only present for `unlink`, `remove`, and `unlinkat`, none of which can operate on files so this was pretty much always a noop. I think this was just carried over without thinking too hard, but this shouldn't be necessary. This was the only usage of the `close_streams` callback so there's no need to preserve it.
pchickey
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was only present for
unlink,remove, andunlinkat, none of which can operate on files so this was pretty much always a noop. I think this was just carried over without thinking too hard, but this shouldn't be necessary. This was the only usage of theclose_streamscallback so there's no need to preserve it.