Feature/unified ground station bringup - #9
Open
Haroldmin1028 wants to merge 6 commits into
Open
Conversation
Contributor
Author
|
Addressed comments and fixed PR.
|
yassinsolim
requested changes
Jul 27, 2026
yassinsolim
left a comment
Member
There was a problem hiding this comment.
Changes Requested
Reviewed and tested commit 7d7523b.
The unified launch works when the full workspace is built, but these issues need to be fixed before merging:
-
Temporary diagnostics publisher crashes
ground_station.launch.pypassesmode: mock.- The publisher only accepts
normal,fault,stale, orcycle. - Enabling
start_temporary_diagnostics_publishercauses an immediateValueError.
-
Build instructions exclude the RViz plugin
BuildInstructions.mdandscripts/check_waybionic_ws.shonly buildwaybionic_descriptionandwaybionic_bringup.- A fresh build opens RViz without the diagnostics panel because
waybionic_rviz_pluginsis not installed. - Build the full workspace or include all three packages.
- Add
waybionic_rviz_pluginsas anexec_dependinwaybionic_bringup/package.xml.
-
The new launch test is not actually running
test_ground_station_launch.pyis not registered inCMakeLists.txt.- CI only runs the existing lint and metadata tests.
- The test also uses
process=Noneand immediately passes without confirming that the expected nodes remain alive. - Register it with
add_launch_testand assert the expected processes or diagnostics topic.
-
Generated Python cache was committed
- Remove the committed
__pycache__/*.pycfile. - Add
__pycache__/and*.pycto.gitignore.
- Remove the committed
I verified the full build and RViz startup on Ubuntu and macOS. These failures are not macOS-specific. Once these issues are fixed and CI runs the real launch test, this should be ready to approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed commands to run ground station to a single command
Created
ground_station.launch.pyfor a unified launch processAdded passing smoke tests
Updated BuildInstructions.md
Validation logs: