Repository navigation
fix(holiday): use standard Wikimedia thumbnail size and load images once - #1278
Merged
Merged
Conversation
Wikimedia only serves thumbnails at its standard widths, so the 640px pumpkin and ghost URLs returned 400. Switch them to 120px; the sprites render at about 30px. The animation also created a new Image for every sprite on every frame (about 1000 requests/sec), so a failing URL was requested again on every frame. Load each image once and skip ones that haven't loaded or failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AjBJekNgjZKdL2oSVY4PUe
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Chrome marks a failed image complete before its onerror runs, and drawImage throws on it, so the naturalWidth check is what keeps draw() safe. Deleting the map entry in onerror was redundant; drop it and the !image check it required. Also correct the comment: same-URL loads are merged, so the old code re-requested each failed URL once per frame, not once per sprite. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 1, 2026
## [1.56.3](v1.56.2...v1.56.3) (2026-11-01) ### Bug Fixes * **holiday:** use standard Wikimedia thumbnail size and load images once ([#1278](#1278)) ([5202ee2](5202ee2))
|
🎉 This PR is included in version 1.56.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wikimedia only serves thumbnails at its standard widths, so the 640px pumpkin and ghost URLs returned 400. Switch them to 120px; the sprites render at about 30px.
The animation also created a new Image for every sprite on every frame (about 1000 requests/sec), so a failing URL was requested again on every frame. Load each image once and skip ones that haven't loaded or failed.