Skip to content

fix(profile): only offer account linking to local sign-ins #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mygod merged 6 commits into from
Nov 2, 2026
Merged

fix(profile): only offer account linking to local sign-ins #1261

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
85267a0
fix(auth): link Discord and Telegram for users signed in with either
Fabio1988 Oct 9, 2026
6219114
fix(auth): address review on account linking
Fabio1988 Oct 9, 2026
75d533b
fix(auth): expire linked trial perms and keep linked webhook
Fabio1988 Oct 15, 2026
70e784a
fix(auth): clear linked trial perms even when the session is a donor
Fabio1988 Oct 27, 2026
5ff94c9
fix(auth): only link accounts from a local sign-in
Fabio1988 Oct 30, 2026
bd4bb8b
fix(profile): only offer account linking to local sign-ins
Fabio1988 Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/features/profile/LinkAccounts.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ export function LinkAccounts() {
)

const [refreshing, setRefreshing] = React.useState(false)
// only a local session (which carries no strategy) can link accounts, and
// pick which one alerts, Discord and Telegram sign-ins use their own
const isLocal = !['discord', 'telegram'].includes(auth.strategy)
const showWebhookStrategy = isLocal && !!auth.discordId && !!auth.telegramId

const [setWebhookStrategy] = useMutation(Query.user('SET_WEBHOOK_STRATEGY'))

Expand All @@ -35,6 +39,7 @@ export function LinkAccounts() {
<Grid2 container alignItems="center" justifyContent="center">
{METHODS.map((method, i) => {
if (!auth.methods.includes(method)) return null
if (!auth[`${method}Id`] && !isLocal) return null
const Component = i ? (
<TelegramLogin
authUrl={telegramAuthUrl}
Expand All @@ -61,7 +66,7 @@ export function LinkAccounts() {
</Grid2>
)
})}
{auth.discordId && auth.telegramId && (
{showWebhookStrategy && (
<Grid2 container alignItems="center" justifyContent="center">
<Grid2 xs={6} sm={6} md={5} textAlign="center" padding="20px 0">
<Typography>{t('select_webhook_strategy')}</Typography>
Expand Down
Loading