Fix RADV launch option validation - #1301
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the launch-option failure reported in #1300.
The RADV performance-test widget was still exposing historical values such as
sam,gpl, andruse, while the semantic catalog only accepts the current Mesa RADV values. In addition, list-valued environment options such asRADV_PERFTEST=nggc,rtcpswere being validated as one value instead of validating each comma-separated member.Changes
Expected result
Selections such as:
can be prepared and applied, while unsupported list members are still rejected with a useful diagnostic.
Fixes #1300