Hey,
I ran into a snag with the latest tag (v2.2.3).
When I try to build the package from source in a clean virtual environment (e.g., running pip install . or installing via git+https), the build fails. It looks like it’s trying to compile the Cython (.pyx) files before Cython and NumPy are installed, so it errors out with “unknown file type '.pyx'.”
From what I can tell, this happens because there’s no pyproject.toml file. Modern pip versions (using PEP 517) look for this file to know they need to install Cython and NumPy in a temporary, isolated environment before starting the build. Without it, the build script just runs and fails.
I went ahead and made a quick patch, added a pyproject.toml and cleaned up the setup.py a bit. With these changes, it builds from source ok now. Here’s my branch if you want to check it out: https://github.com/nicoaira/forgi/tree/v2.2.3-patch
It would be amazing if you could tag a new patch release (like v2.2.4) with this fix.
Thanks!
Hey,
I ran into a snag with the latest tag (v2.2.3).
When I try to build the package from source in a clean virtual environment (e.g., running pip install . or installing via git+https), the build fails. It looks like it’s trying to compile the Cython (.pyx) files before Cython and NumPy are installed, so it errors out with “unknown file type '.pyx'.”
From what I can tell, this happens because there’s no pyproject.toml file. Modern pip versions (using PEP 517) look for this file to know they need to install Cython and NumPy in a temporary, isolated environment before starting the build. Without it, the build script just runs and fails.
I went ahead and made a quick patch, added a pyproject.toml and cleaned up the setup.py a bit. With these changes, it builds from source ok now. Here’s my branch if you want to check it out: https://github.com/nicoaira/forgi/tree/v2.2.3-patch
It would be amazing if you could tag a new patch release (like v2.2.4) with this fix.
Thanks!