ci(frontend): add OWNERS file to enable Prow approve workflow - #1165
Merged
Merged
Conversation
Tide requires both the 'lgtm' and 'approved' labels to merge, but the 'approved' label can only be granted via /approve by an approver listed in an OWNERS file. Without this file no one can approve, so PRs stay blocked. Copied the approvers from website_backend2.
TwoDCube
added
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: TwoDCube The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a root
OWNERSfile so Prow'sapproveplugin has a list of approvers.Why
Tide is configured to require both the
lgtmandapprovedlabels before merging (seewebsite_k8s/verseghy-website/prow/configmaps.yaml). Theapprovedlabel is only granted when an approver listed in anOWNERSfile runs/approve. This repo has noOWNERSfile, so no one can grantapprovedand PRs (e.g. #1164) stay permanentlyBLOCKEDeven withlgtm.Approvers copied from
website_backend2:Note
This bootstrap PR may itself be blocked by the same mechanism (base branch has no OWNERS yet), so it likely needs an admin merge / direct push to
master. Once it lands, #1164 and other open PRs can be unblocked with/approve.