Conversation
The menu resolvers only added page_id to the SQL selection when link was
requested, but page_id is what slug needs, so `{ menu { slug } }` returned
null slugs. Select page_id when slug is requested.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TwoDCube The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
verseghy-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug recorded by the tests in #247. Stacked on #256 (base
fix/soft-deleted-menu-items), because both change the same lines ofmenu.rs. This is a draft until #246, #247 and #256 merge.Bug
menuandMenuItem.childrenaddedpage_idto the SQL selection only whenlinkwas requested, butslugis the field that needspage_id.{ menu { name slug } }therefore returnedslug: nullfor every item. website_frontend2 always selectslinktogether withslug, so the site is not affected today.Fix
Select
page_idwhenslugis requested.linkis a plain column and never needed it.Tests
menu_slug_does_not_depend_on_selecting_linkis no longer ignored, and now also checks a child item's slug.linkas well.cargo clippy --workspace --all-targets -D warningsis clean.CI=true cargo test --workspacepasses against MySQL 8.4 and Redis 6.2.🤖 Generated with Claude Code