Conversation
The canteen resolver unwrapped the ISO week bounds, so a week that does not exist in the requested year (0, negative, 54, or 53 in a 52-week year) panicked and the request failed with HTTP 500. Return an "invalid week" error instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TwoDCube The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
verseghy-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug recorded by the tests in #247. Stacked on #247 (base
test/integration), so this is a draft until #246 and #247 merge.Bug
canteen(year, week)called.unwrap()on the ISO week bounds. Any week that does not exist in the requested year panicked, and the panic middleware answered with HTTP 500. That includes 0, negative numbers, 54, and 53 in a year with 52 ISO weeks.Fix
Return the GraphQL error
invalid weekinstead. Theeventsresolver already reports invalid months asinvalid datethe same way.Tests
nonexistent_canteen_week_is_a_graphql_erroris no longer ignored. It now checks weeks 0, -1 and 54 of 2026, plus week 53 of 2025 (a 52-week year; 2026 has 53), and expects HTTP 200 with exactly theinvalid weekerror.cargo clippy --workspace --all-targets -D warningsis clean.CI=true cargo test --workspacepasses against MySQL 8.4 and Redis 6.2.🤖 Generated with Claude Code