Conversation
trim_trailing_slash was added with Router::layer, and middleware added that way runs after routing, so a request to /graphql/ found no route and got a 404. Wrap the whole router in NormalizePathLayer instead, as axum's documentation on rewriting the request URI in middleware describes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TwoDCube The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
verseghy-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug recorded by the tests in #247. Stacked on #247 (base
test/integration), so this is a draft until #246 and #247 merge.Bug
The middleware stack applied
trim_trailing_slash()withRouter::layer. Per axum 0.8.9's documentation ("Rewriting request URI in middleware"), middleware added withRouter::layerruns after routing, so it cannot change which route matches.POST /graphql/andGET /liveness/returned 404.Fix
app()no longer trims inside the router. It wraps the whole router inNormalizePathLayer::trim_trailing_slash()and returnsIntoMakeService<NormalizePath<Router>>.runandtest-utils) pass the value straight toaxum::serve, so neither needed changes.Tests
trailing_slash_is_ignoredis no longer ignored. It also checksGET /liveness/,/readiness/and/graphql/.cargo clippy --workspace --all-targets -D warningsis clean.CI=true cargo test --workspacepasses against MySQL 8.4 and Redis 6.2.🤖 Generated with Claude Code