Conversation
The GraphQL handler executed any request whose operation name was "IntrospectionQuery" without the database transaction, request counter and config the resolvers expect. The operation name is chosen by the client, so any such operation that selected data panicked and returned HTTP 500. Drop the shortcut: introspection now runs in a transaction like other requests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TwoDCube The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug recorded by the tests in #247. Stacked on #247 (base
test/integration), so this is a draft until #246 and #247 merge.Bug
src/http.rsreturned early for any request withoperationName: "IntrospectionQuery"and executed it without the database transaction, the request counter and the config. Resolvers take those from the context withunwrap()/data_unchecked(). The operation name is chosen by the client, soquery IntrospectionQuery { colleagues { id } }panicked and returned HTTP 500.Fix
Remove the shortcut, so every operation runs with the context the resolvers expect.
Trade-off: introspection now opens and commits a transaction that runs no queries, so it needs MySQL to be reachable. Keeping the shortcut safely would require checking that a document selects only
__schema/__type/__typenamefields. That seems not worth the code for how rarely introspection runs.Tests
operation_named_introspection_query_can_select_datais no longer ignored.introspection_query_is_answeredstill passes.cargo clippy --workspace --all-targets -D warningsis clean.CI=true cargo test --workspacepasses against MySQL 8.4 and Redis 6.2.🤖 Generated with Claude Code