Conversation
Page info looks up the oldest and newest published post and returned "Could not get min value" when there was none, so every post list failed instead of returning no posts. Treat the absence of published posts as a list without neighbouring pages. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TwoDCube The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
verseghy-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug recorded by the tests in #247. Stacked on #247 (base
test/integration), so this is a draft until #246 and #247 merge.Bug
To compute page info, post lists look up the oldest and newest published post. With no published post that lookup found nothing and returned
Could not get min value, soposts,search,author.postsandlabel.postsall failed instead of returning an empty list.Fix
get_published_posts_min_max_idnow returnsNonewhen no post is published, and the connection then has neither a previous nor a next page. The list itself is necessarily empty in that case.The fix for filtered page info (the next PR) stacks on this one. Applying a filter to the lookup without this change would make every empty filtered list fail the same way, for example a label with no posts.
Tests
listing_posts_without_published_posts_returns_an_empty_listis no longer ignored.cargo clippy --workspace --all-targets -D warningsis clean.CI=true cargo test --workspacepasses against MySQL 8.4 and Redis 6.2.🤖 Generated with Claude Code