Conversation
…pped Post lists are ordered by date, then id, both descending, but the cursor filter was `date <= d AND id < i`. A post with a higher id than the cursor's post but an older date, such as one entered later and backdated, failed `id < i` and never appeared on a later page. Filter on `date < d OR (date = d AND id < i)` instead, which matches the ordering. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TwoDCube The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
verseghy-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug recorded by the tests in #247. Stacked on #247 (base
test/integration), so this is a draft until #246 and #247 merge.Bug
Post lists (
posts,search,author.posts,label.posts) are ordered by date, then id, both descending. The cursor filter wasdate <= d AND id < i, so a post with a higher id than the cursor's post but an older date never appeared on a later page. That happens to posts entered later and backdated. With the seed data, paging two at a time stopped after posts[1, 2], skipping 3, 6 and 5.Fix
The rows after a cursor are now
date < d OR (date = d AND id < i), which matches the ordering.beforestill selects the same rows asafter.Tests
paging_through_posts_visits_every_published_post_onceis no longer ignored.paging_orders_posts_with_the_same_date_by_descending_idinserts two posts on the same date as post 2 and checks paging returns[1, 8, 7, 2, 3, 6, 5]. This covers thedate = dbranch.cargo clippy --workspace --all-targets -D warningsis clean.CI=true cargo test --workspacepasses against MySQL 8.4 and Redis 6.2.🤖 Generated with Claude Code