Conversation
The DateTime scalar documents and emits "YYYY-MM-DD HH:MM:SS", but parsed input with NaiveDateTime::from_str, which only accepts the ISO 8601 form with a "T" separator. Parse the documented format first and fall back to the ISO form so existing inputs keep working. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TwoDCube The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
verseghy-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug recorded by the tests in #246. Stacked on #247 (base
test/integration), so this is a draft until #246 and #247 merge.Bug
The
DateTimescalar documents and emits the formatYYYY-MM-DD HH:MM:SS, butparseusedNaiveDateTime::from_str, which only accepts ISO 8601 with aTseparator (YYYY-MM-DDTHH:MM:SS). A client sending back a value it had received gotWrong date format. No current query takes aDateTimeargument, so nothing is broken for clients today.Fix
Parse the documented format first and fall back to the ISO form, so inputs that worked before still work.
parseandto_valuenow share one format constant.Tests
parses_the_format_it_emitsis no longer ignored, andparses_iso_8601_with_a_t_separatorstill passes.cargo clippy --workspace --all-targets -D warningsis clean.CI=true cargo test --workspacepasses against MySQL 8.4 and Redis 6.2.🤖 Generated with Claude Code