Skip to content

fix(governance): allow out-of-order signer approvals without deadlock (#176) - #236

Open
huangji6693-max wants to merge 1 commit into
Vero-protocol:mainfrom
huangji6693-max:fix/multisig-approval-deadlock-176
Open

huangji6693-max wants to merge 1 commit into
Vero-protocol:mainfrom
huangji6693-max:fix/multisig-approval-deadlock-176

Conversation

@huangji6693-max

Copy link
Copy Markdown

Summary

  • Remove the strict signer-index ordering check (current_index <= last_index) in governance::approve() that permanently deadlocked proposals whenever a higher-index signer approved before a lower-index signer.
  • Preserve duplicate-approval rejection (GovError::AlreadyApproved), signer membership validation (GovError::NotASigner), and stake-gate checks.
  • Add regression test out_of_order_approval_still_reaches_threshold verifying that a 2-of-3 multisig reaches quorum when signer index 2 approves before signer index 1.

Verification

running 12 tests
test governance::tests::out_of_order_approval_still_reaches_threshold ... ok
test governance::tests::threshold_transition_sets_unlock ... ok
...
test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured

Closes #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Multi-sig proposal approval permanently deadlocks when a higher-index signer approves before a lower-index signer

1 participant