Skip to content

🧪 Add Edge Case Tests for FindExe#95

Open
Ven0m0 wants to merge 2 commits intomainfrom
add-findexe-tests-15906180683183079949
Open

🧪 Add Edge Case Tests for FindExe#95
Ven0m0 wants to merge 2 commits intomainfrom
add-findexe-tests-15906180683183079949

Conversation

@Ven0m0
Copy link
Copy Markdown
Owner

@Ven0m0 Ven0m0 commented Apr 29, 2026

🎯 What: Improved the testing and logic for edge cases in the FindExe function, including cases where the PATH entries contain trailing slashes, target files are nested inside subdirectories, the file name is an empty string, or the fallback list is empty.
📊 Coverage: Now tests checking for empty fallbacks, empty inputs, subdirectory paths, and trailing slashes in environments variable are available.
Result: Test coverage for FindExe has broadened. The logic for edge cases has also been made robust. The FindExe function itself was tweaked to trim path separators correctly to avoid invalid double slashes in concatenated filepaths, and correctly handles being queried for empty executable names which AHK's FileExist considers falsy (but returning directory path information otherwise) and thus averting potential bugs in consumer code paths relying on correctly resolved exact files.


PR created automatically by Jules for task 15906180683183079949 started by @Ven0m0

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented Apr 29, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • Lib/v2/AHK_Common.ahk
  • tests/FindExe_Test.ahk

2 similar comments
@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented Apr 29, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • Lib/v2/AHK_Common.ahk
  • tests/FindExe_Test.ahk

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented Apr 29, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • Lib/v2/AHK_Common.ahk
  • tests/FindExe_Test.ahk

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented Apr 29, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • Lib/v2/AHK_Common.ahk (FindExe improvements: empty name handling, path trimming)
  • tests/FindExe_Test.ahk (added edge case tests for trailing slashes, subdirectories, empty inputs)
  • .github/workflows/ahk-lint-format-compile.yml (workflow reliability improvement only)

Reviewed by nemotron-3-super-120b-a12b-20230311:free · 4,063,715 tokens

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant