Skip to content

🧪 Add tests for Lossless_Scaling_Manager ToggleLS logic#92

Open
Ven0m0 wants to merge 1 commit intomainfrom
jules-9839411731292030670-ca533597
Open

🧪 Add tests for Lossless_Scaling_Manager ToggleLS logic#92
Ven0m0 wants to merge 1 commit intomainfrom
jules-9839411731292030670-ca533597

Conversation

@Ven0m0
Copy link
Copy Markdown
Owner

@Ven0m0 Ven0m0 commented Apr 29, 2026

🎯 What: The testing gap addressed
The ToggleLS function in Lossless_Scaling_Manager.ahk lacked unit tests because it relied on the built-in ProcessExist and invoked side-effect functions StartLS and StopLS. The environment setup also prevented simple test inclusion due to direct execution side-effects.

📊 Coverage: What scenarios are now tested

  1. Refactored Lossless_Scaling_Manager.ahk to wrap execution side-effects with condition to only run when the main script.
  2. Refactored ToggleLS to use dependency injection, accepting optional function references for ProcessExist, StartLS, and StopLS.
  3. Created a new test suite tests/Other/Lossless_Scaling_Manager_Test.ahk that asserts:
    • When the process exists, StopLS is correctly called.
    • When the process does not exist, StartLS is correctly called.

Result: The improvement in test coverage
ToggleLS behavior is now verified robustly without touching actual processes or system state.


PR created automatically by Jules for task 9839411731292030670 started by @Ven0m0

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant